Datadog Report

Branch report: anna/asm/add-sessionid-beginning-request
Commit report: b9e859b
Test service: dd-trace-dotnet

❌ 121 Failed (0 Known Flaky), 244485 Passed, 2226 Skipped, 18h 48m 39.81s Total Time

❌ Failed Tests (121)

This report shows up to 5 failed tests.

• TestAuthenticatedRequest - Datadog.Trace.Security.IntegrationTests.AspNetCore5AutoUserEventsDefaultModeSecurityEnabled - Details

  Expand for error

   Results do not match.
   Differences:
   Received: Security.AspNetCore5AutoUserEvents.SecurityOn.defaultmode-TestAuthenticatedRequest.received.txt
   Verified: Security.AspNetCore5AutoUserEvents.SecurityOn.defaultmode-TestAuthenticatedRequest.verified.txt
   Received Content:
   [
     {
       TraceId: Id_1,
       SpanId: Id_2,
       Name: aspnet_core.request,
   ...
  

• TestAuthenticatedRequest - Datadog.Trace.Security.IntegrationTests.AspNetCore5AutoUserEventsDefaultModeSecurityEnabled - Details

  Expand for error

   Results do not match.
   Differences:
   Received: Security.AspNetCore5AutoUserEvents.SecurityOn.defaultmode-TestAuthenticatedRequest.received.txt
   Verified: Security.AspNetCore5AutoUserEvents.SecurityOn.defaultmode-TestAuthenticatedRequest.verified.txt
   Received Content:
   [
     {
       TraceId: Id_1,
       SpanId: Id_2,
       Name: aspnet_core.request,
   ...
  

• TestAuthenticatedRequest - Datadog.Trace.Security.IntegrationTests.AspNetCore5AutoUserEventsDefaultModeSecurityEnabled - Details

  Expand for error

   Results do not match.
   Differences:
   Received: Security.AspNetCore5AutoUserEvents.SecurityOn.defaultmode-TestAuthenticatedRequest.received.txt
   Verified: Security.AspNetCore5AutoUserEvents.SecurityOn.defaultmode-TestAuthenticatedRequest.verified.txt
   Received Content:
   [
     {
       TraceId: Id_1,
       SpanId: Id_2,
       Name: aspnet_core.request,
   ...
  

• TestAuthenticatedRequest - Datadog.Trace.Security.IntegrationTests.AspNetCore5AutoUserEventsDefaultModeSecurityEnabled - Details

  Expand for error

   Results do not match.
   Differences:
   Received: Security.AspNetCore5AutoUserEvents.SecurityOn.defaultmode-TestAuthenticatedRequest.received.txt
   Verified: Security.AspNetCore5AutoUserEvents.SecurityOn.defaultmode-TestAuthenticatedRequest.verified.txt
   Received Content:
   [
     {
       TraceId: Id_1,
       SpanId: Id_2,
       Name: aspnet_core.request,
   ...
  

• TestAuthenticatedRequest - Datadog.Trace.Security.IntegrationTests.AspNetCore5AutoUserEventsDefaultModeSecurityEnabled - Details

  Expand for error

   Results do not match.
   Differences:
   Received: Security.AspNetCore5AutoUserEvents.SecurityOn.defaultmode-TestAuthenticatedRequest.received.txt
   Verified: Security.AspNetCore5AutoUserEvents.SecurityOn.defaultmode-TestAuthenticatedRequest.verified.txt
   Received Content:
   [
     {
       TraceId: Id_1,
       SpanId: Id_2,
       Name: aspnet_core.request,
   ...
  

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

• This PR (6623)
• master

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

• Welch test with statistical test for significance of 5%
• Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6623) - mean (69ms)  : 66, 71
     .   : milestone, 69,
    master - mean (69ms)  : 66, 72
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6623) - mean (991ms)  : 968, 1014
     .   : milestone, 991,
    master - mean (992ms)  : 960, 1024
     .   : milestone, 992,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6623) - mean (102ms)  : 100, 104
     .   : milestone, 102,
    master - mean (102ms)  : 100, 104
     .   : milestone, 102,

    section CallTarget+Inlining+NGEN
    This PR (6623) - mean (670ms)  : 650, 691
     .   : milestone, 670,
    master - mean (674ms)  : 659, 690
     .   : milestone, 674,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6623) - mean (89ms)  : 87, 91
     .   : milestone, 89,
    master - mean (89ms)  : 87, 91
     .   : milestone, 89,

    section CallTarget+Inlining+NGEN
    This PR (6623) - mean (625ms)  : 606, 645
     .   : milestone, 625,
    master - mean (630ms)  : 615, 645
     .   : milestone, 630,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6623) - mean (191ms)  : 186, 196
     .   : milestone, 191,
    master - mean (191ms)  : 188, 195
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (6623) - mean (1,102ms)  : 1072, 1132
     .   : milestone, 1102,
    master - mean (1,105ms)  : 1077, 1133
     .   : milestone, 1105,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6623) - mean (271ms)  : 266, 275
     .   : milestone, 271,
    master - mean (272ms)  : 266, 278
     .   : milestone, 272,

    section CallTarget+Inlining+NGEN
    This PR (6623) - mean (863ms)  : 820, 905
     .   : milestone, 863,
    master - mean (868ms)  : 834, 903
     .   : milestone, 868,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6623) - mean (265ms)  : 259, 271
     .   : milestone, 265,
    master - mean (262ms)  : 258, 266
     .   : milestone, 262,

    section CallTarget+Inlining+NGEN
    This PR (6623) - mean (850ms)  : 819, 881
     .   : milestone, 850,
    master - mean (849ms)  : 811, 886
     .   : milestone, 849,

Benchmarks Report for appsec 🐌

Benchmarks for #6623 compared to master:

• 2 benchmarks are slower, with geometric mean 1.123
• 2 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

• Mann–Whitney U test with statistical test for significance of 5%
• Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks Report for tracer 🐌

Benchmarks for #6623 compared to master:

• 2 benchmarks are faster, with geometric mean 1.149
• All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

• Mann–Whitney U test with statistical test for significance of 5%
• Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Snapshots difference summary

The following differences have been observed in committed snapshots. It is meant to help the reviewer.
The diff is simplistic, so please check some files anyway while we improve it.

36 occurrences of :

-      _dd.appsec.fp.session: ssn--bd9bce81-d0fff5a7-,
+      _dd.appsec.fp.session: ssn--bd9bce81-d0fff5a7-<SessionFp>,

82 occurrences of :

+      _dd.appsec.fp.session: ssn----<SessionFp>,

1 occurrences of :

-      _dd.appsec.fp.session: ssn-5860faf0---,
+      _dd.appsec.fp.session: ssn-5860faf0---<SessionFp>,

11 occurrences of :

-      _dd.appsec.fp.session: ssn-<fingerprint>,
+      _dd.appsec.fp.session: ssn-7bcd1c9f---<SessionFp>,

3 occurrences of :

-      _dd.appsec.fp.session: ssn-<fingerprint>,
+      _dd.appsec.fp.session: ssn-ef8eb89f---<SessionFp>,

50 occurrences of :

+      _dd.appsec.fp.session: ssn--<CookieFields>-<CookieValues>-<SessionFp>,

3 occurrences of :

-      _dd.appsec.s.req.cookies: [{"cookie-key":[8]}],
+      _dd.appsec.s.req.cookies: [{"ASP.NET_SessionId":[8],"cookie-key":[8]}],